Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kafka worker from reference config. #32440

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Remove Kafka worker from reference config. #32440

merged 1 commit into from
Jul 22, 2022

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jul 21, 2022

Follow up from #31978 where the worker documentation was removed but the setting was not removed from the reference configuration file.

Quoting the original reasoning for removing this:

@cmacknz cmacknz added docs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jul 21, 2022
@cmacknz cmacknz requested a review from a team as a code owner July 21, 2022 14:21
@cmacknz cmacknz self-assigned this Jul 21, 2022
@cmacknz cmacknz requested review from a team as code owners July 21, 2022 14:21
@cmacknz cmacknz requested review from faec and leehinman and removed request for a team July 21, 2022 14:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 21, 2022
@cmacknz cmacknz mentioned this pull request Jul 21, 2022
Closed
6 tasks
@cmacknz cmacknz added backport-v8.0.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Jul 21, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 21, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-21T16:52:38.182+0000

  • Duration: 53 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 2308
Skipped 5
Total 2313

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member Author

cmacknz commented Jul 21, 2022

/test

@cmacknz
Copy link
Member Author

cmacknz commented Jul 21, 2022

/test libbeat

@cmacknz cmacknz merged commit 111d150 into elastic:main Jul 22, 2022
mergify bot pushed a commit that referenced this pull request Jul 22, 2022
@cmacknz @mergify
Remove Kafka worker from reference config. (#32440)
92e3819 
Follow up from #31978

(cherry picked from commit 111d150)
@mergify mergify bot mentioned this pull request Jul 22, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 22, 2022
@cmacknz @mergify
Remove Kafka worker from reference config. (#32440)
4a56d1d 
Follow up from #31978

(cherry picked from commit 111d150)
@mergify mergify bot mentioned this pull request Jul 22, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 22, 2022
@cmacknz @mergify
Remove Kafka worker from reference config. (#32440)
f21e522 
Follow up from #31978

(cherry picked from commit 111d150)
@mergify mergify bot mentioned this pull request Jul 22, 2022
Merged
@cmacknz cmacknz deleted the remove-kafka-worker-reference-config branch July 22, 2022 12:20
cmacknz added a commit that referenced this pull request Jul 22, 2022
@mergify @cmacknz
Remove Kafka worker from reference config. (#32440) (#32463)
c5d4fa5 
Follow up from #31978

(cherry picked from commit 111d150)

Co-authored-by: Craig MacKenzie <[email protected]>
cmacknz added a commit that referenced this pull request Jul 22, 2022
@mergify @cmacknz
Remove Kafka worker from reference config. (#32440) (#32464)
03c7b78 
Follow up from #31978

(cherry picked from commit 111d150)

Co-authored-by: Craig MacKenzie <[email protected]>
cmacknz added a commit that referenced this pull request Jul 22, 2022
@mergify @cmacknz
Remove Kafka worker from reference config. (#32440) (#32465)
ddf8132 
Follow up from #31978

(cherry picked from commit 111d150)

Co-authored-by: Craig MacKenzie <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @cmacknz
Remove Kafka worker from reference config. (elastic#32440) (elastic#3…
4c5e604 
…2464)

Follow up from elastic#31978

(cherry picked from commit b5ed75d)

Co-authored-by: Craig MacKenzie <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@cmacknz @chrisberkhout
Remove Kafka worker from reference config. (#32440)
fb6461b 
Follow up from #31978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faec faec faec approved these changes

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@cmacknz cmacknz

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify docs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmacknz @elasticmachine @faec